search

raidionics / Raidionics

Software for automatic segmentation and generation of standardized clinical reports of brain tumors from MRI volumes
https://raidionics.github.io/
BSD 2-Clause "Simplified" License
31 stars 4 forks source link

Remove .raidionics/ directory during install and uninstall for Windows #36

Closed andreped closed 1 year ago

andreped commented 1 year ago

This is related to issue https://github.com/dbouget/Raidionics/issues/5.

Note that this PR only adds the fix for Windows, but I believe this is most critical there as most of the users are on Windows.

Doing the same for Linux is likely bad practice as the .raidionics/ directory is likely created in the home directory (see this discussion).

For macOS, I'm really not sure if this makes sense, as deletion of app bundles are done in a very different way. The bundles themselves are essentially just folders which lie in /Applications or similar. Deleting them means to delete the folder and nothing more. There is a discussion regarding this here.

We should also consider creating the .raidionics/ directory in a different directory in the future. I believe the C:/Users/some-user/AppData/Local/ might be suitable, but not sure.

andreped commented 1 year ago

Could be an idea to delete the .raidionics/ directory the first time the program is being launched, if there is a sensible way of catching that (before creating it again, that is).

andreped commented 1 year ago

I highlighted it better that the user needs to delete the .raidionics/ directory themselves. If they forget, on Windows it should still be deleted, but for UNIX systems lets just hope they do this.

Again, as there is no natural way to delete the .raidionics/ directory for macOS, I would likely attempt to delete it during initial program launch.

andreped commented 1 year ago

I also cropped the GIF in the README.