Open andreped opened 11 months ago
Also note that CIs take A LOT longer to run due to the generated installers being a lot larger, as uploading these artifacts takes an extremely amount of time.
Removing the binaries, also removed the "Free up GitHub Actions Ubuntu Runner Disk Space
step (see here) which surprisingly takes almost 6 (!) minutes to perform.
Overall it seems like build times on Ubuntu increases by 20 minutes (30 -> 50 minutes) with having the C++ binaries. But this also affects the other CIs for respective OS and CPU.
Better to use the C++ ANTs as it's updated more frequently than the Python package, and the Python package does not run on the mac M1. The issue with the c++ ANTs in Windows is that it is not possible to subprocess a bash script, would need to rewrite in Raidionics the content to just call the .exe in the end.
Is your feature request related to a problem? Please describe. As we are not using the C++ binaries, and it does not even work on Windows and the PyANTs works fine, I say that we should just remove the ANTs C++ binaries all together.
This will greatly reduce the installer size, which was increased by about 3x in size, just to do the ANTs binaries alone.