search

raiguard / EditorExtensions

Extends the Factorio map editor with new features, testing tools, and other utilities to aid with sandbox play and scenario creation.
https://mods.factorio.com/mod/EditorExtensions
Other
28 stars 8 forks source link

large BlueprintBooks vanish in InventorySync #8

Closed Calibretto22 closed 4 years ago

Calibretto22 commented 4 years ago

I have rather large Blueprint-Books in my game. With the new Feature "Inventory sync" some books are reliably destroyed, when switching in editor-mode.

This does not happen when Sync is disabled.

Perhaps you can announce the feature and this downside a bit more prominently.

Also: syncing of inventoryfilters would be great.

Link: savegame where books vanish reliably.

raiguard commented 4 years ago

Thanks for sending a save game, I'll look into it.

For the record though, inventory sync has been in the mod for like two months, it's not new. :D

raiguard commented 4 years ago

Geez... with that many blueprint books, syncing the inventories takes forever! I would recommend keeping those in the blueprint library instead to make syncing far more performant.

I think the problem stems from the fact that your inventory has slot filters. I never tested inventory sync with slot filters, and thinking about it, it would probably lose some items because it tries to set_stack on a certain spot that has a filter for a different item, so it fails. Syncing the slot filters as well as the contents should fix this.

As for syncing inventory filters, that is impossible. Inventory filters only exist in the map editor, so there's nothing to "sync" at all. Sorry!

Calibretto22 commented 4 years ago

Thanks for looking into it. It could be, that I did not enter the editor for some time. Today was the first time I noticed the considerable lag, when entering the editor. Since the lag did not occur when the game was vanilla I started looking for options in the mods.

(in my first comment I meant the slot filters)

For now i just disabled the sync. That's fine for me.

Thanks for the great mod.

Calibretto22 commented 4 years ago

(it's okay if you want to close the issue.)

raiguard commented 4 years ago

I'll close this once I fix the bug :D

raiguard commented 4 years ago

image

The mod will now sync inventory filters, fixing this issue. However, it still takes an obscenely long time to sync your blueprint books, so I would either move those to the blueprint library, or just not use inventory sync at all. I will contact the developers to see if they can make any performance improvements to that logic.