raiguard / ModernGadgets

Sleek, minimalist, information-dense gadgets for the modern desktop. Inspired by the AddGadgets.com system monitoring gadgets. Built on the Rainmeter platform.
MIT License
300 stars 32 forks source link

Change Gadget Logo and it's Color? #273

Closed Alex-Mirov closed 2 years ago

Alex-Mirov commented 2 years ago

Hello

It is possible to add this option?

I think it would be nice to have such a feature like this.

Thanks

SilverAzide commented 2 years ago

Both the CPU Meter and GPU Meter already do this for the colors (not the logo). Are you not seeing this?

Alex-Mirov commented 2 years ago

Hello

I'm new to work the rainmeter gadgets and somehow i missed it! Where is this setting?

Thanks

SilverAzide commented 2 years ago

There is no setting, it is already done automatically. The only thing you might want to change is the shade of the colors, but they are already colored exactly per your original suggestion. (The icon/logo shapes are a different issue.)

image

Alex-Mirov commented 2 years ago

My gpu gadget logo still have the blue color on them and i have nvidia gpu.

SilverAzide commented 2 years ago

Did you configure HWiNFO to see your GPU? If you have a system with two GPUs (the built-in Intel one and a dedicated nVidia one), then HWiNFO may be seeing your Intel GPU instead. It might help if you posted a screenshot.

Alex-Mirov commented 2 years ago

Actually i have nvidia and amd gpus on the same pc, yes i know it's weird. How do i config the hwinfo to see the gpus?

SilverAzide commented 2 years ago

HWiNFO Configuration

Alex-Mirov commented 2 years ago

I've managed to set to auto detect name for the gpus, but colors of the gadgets are still blue! Please forgive me i'm new for this stuff.

Alex-Mirov commented 2 years ago

GPU Gadgets

SilverAzide commented 2 years ago

I see the problem now, thanks for the screenshot! It looks like there's a bug that was introduced in v1.8.0. Raiguard will need to fix this. The measure [MeasureGpuName] is stripping off the GPU manufacturer name, and then the code that triggers the color change no longer works as a result. (I didn't notice as I am using an older version.)

Alex-Mirov commented 2 years ago

Glad to know that is actual bug that being discovered!
Do i need to upload some debug files for analyze?

SilverAzide commented 2 years ago

Nah... I'm sure raiguard can spot the issue immediately, it is pretty simple. 🙂

Jordilavila commented 2 years ago

Hi!

Open the file GpuMeterBody.inc and add the next lines at the end of the section called [MeasureGpuName]:

IfMatch5=(?i)(.*GeForce*.)
IfMatchAction5=[!SetOption MeterGpuIcon Fill "Fill Color #colorNvidia#"][!UpdateMeter MeterGpuIcon]

It happens because the name of the GPU not contains the word NVidia.

raiguard commented 2 years ago

Hey, thanks SilverAzide for helping with this, and thanks Jordilavila for the fix. I would have fixed this a while ago, but I had to unexpectedly re-image my PC a while back and haven't re-set-up my Windows VM yet. Rest assured that I will fix this sometime soon.

Alex-Mirov commented 2 years ago

Hello

Many thanks Jordilavila for the fix! The color works for nvidia and amd gpus!

Thanks

Alex-Mirov commented 2 years ago

I also want to thank SilverAzide for the help to discover the bug!

Alex-Mirov commented 2 years ago

Thank to raiguard for giving attention for this Issue!