Factorio mods localization - feedback

raiguard / RecipeBook

Recipe Book for Factorio.

MIT License

20 stars 9 forks source link

Factorio mods localization - feedback #158

Closed dima74 closed 5 months ago

dima74 commented 6 months ago

Hi @raiguard! I noticed you recently uninstalled factorio-mods-localization. If possible, could you please provide some feedback, maybe something that could be improved? Thanks!

raiguard commented 6 months ago

Hey, my including the mod in that project in the first place was a complete accident. I didn't notice for several months because I have been neck-deep in work and IRL stuff.

I have my own Crowdin project with my own script to sync as a part of my release workflow.

The primary thing that kept me from simply using your project is that your project makes PRs / commits every week. There is no way for me to "pull" translations as a part of my release workflow. If you could add a way to do that then I might ditch my janky in-house solution in favor of your much more battle-tested solution.

Thanks!

dima74 commented 6 months ago

Thanks for the feedback! I added option to do this, please see "Disable weekly updates from Crowdin" section

raiguard commented 6 months ago

Thank you! I will take a look at that and see if I can integrate it into my workflow.

raiguard commented 5 months ago

I have taken a look at it, and while it is an improvement, there are still a few fundamental issues:

Running it manually pushes a commit to the repository. I would like to pull the translations into my local clone instead.
The project is a GitHub app, locking me into this platform, which I do not like.

I appreciate your effort (seriously, thank you for your work, it's amazing!), but it's just not for me. Accommodating my requests would probably require a lot more work than it's worth. I'll continue using my own solution.

Thanks!