raiguard / TaskList

A simple and unobtrusive todo list for Factorio.
https://mods.factorio.com/mod/TaskList
MIT License
10 stars 9 forks source link

Pressing "e" with the main task list visible should create a new task #10

Closed macintacos closed 2 years ago

macintacos commented 2 years ago

When I was learning how to play the game, several of the in-game hints let you know that hitting "e" will click whatever button on-screen is green at the time. This is pretty consistent in vanilla UI elements and menus.

With that in mind, I hit "e" when I was in the main task list, expecting it to create a new task (since the new task button is green). Turns out, it closes the window. I think it'd make a ton of sense if pressing "e" when you're in the main task list would bring up the new task UI.

Fantastic mod by the way - I've been dying for someone to come up with a simple task list UI that doesn't look horrible, and finally someone has delivered 😄

raiguard commented 2 years ago

Keep in mind also that you can bind a hotkey to directly open the new task window. There is no hotkey by default so it's not obvious.

smunstu commented 2 years ago

I see this feature was added to the latest version of this mod. I really think this should have been incorporated in a toggleable way - I tend to play with my task list open nearly all the time, and now I'm constantly accidentally opening the new task dialog when I'm intending to open the inventory/crafting menu.

Edit: This is actually not necessary after all; the desired behavior can be obtained simply by pinning the Tasks list. Thanks for making this mod so well. It's such a simple thing, but it is really one of my favorite mods!

raiguard commented 2 years ago

Yeah, I intentionally made it so it will only work if you don't have it pinned. If you have it pinned, you usually have another window open at the same time, so I didn't want to cause pain.

tldrlol commented 2 years ago

I see this feature was added to the latest version of this mod. I really think this should have been incorporated in a toggleable way - I tend to play with my task list open nearly all the time, and now I'm constantly accidentally opening the new task dialog when I'm intending to open the inventory/crafting menu.

Thank you for putting in the effort to make this mod more consistent with the rest of the Factorio UI. However, in my experience this makes the mod less consistent.

For practically any other window that comes to mind that accepts the E button, it is tied to an Accept/Okay/Close type behavior. In other words pressing E repeatedly works to close and unwind the current stack of focused windows. With this feature, the window stack is expanded instead.

I second the idea to at least add a toggle such that the E button closes the task list instead, so as to alleviate the newly introduced annoyance I have with this mod without causing frustration for others.

raiguard commented 2 years ago

The base game doesn't actually use a green plus button anywhere that I can remember, so the boundary here is unclear. But, I kind of agree with you. I'll ad an option for it, and it will be disabled by default.