search

railcore / configs

Configs for RailCore Printers
MIT License
15 stars 20 forks source link

Changes to config.g #60

Closed TurtlePrint closed 5 years ago

TurtlePrint commented 5 years ago

3 commits for updates to the config.g file. This is my first attempt at using GitHub so please let me know if I'm doing something wrong. Thanks.

dandancheeseandham commented 5 years ago

TurtlePrint,

First, thank you very much for the commits. I was new to Github when I first started, so don't be shy - I've done plenty "wrong" myself, and kudos for giving a go! These look reasonable to me, but I'd like to verify the extruder max jerk.

Just two small pieces of advice. :smiley: i) The general consenus appears to be "fix one issue per PR". To clarify, if you were fixing something to do with the extruder, then this could be many lines and even over many files - but still one issue. (theres various benefits to this simple guideline) ii) A good title for the PR - what are you trying to achieve? This feeds into the first piece of advice. :smile:

Once again though, thanks!

dandancheeseandham commented 5 years ago

Changed to 1300 and merged into https://github.com/railcore/configs/blob/master/duet/sys/config-user%20examples/config-user.kit