Closed andreblanke closed 1 month ago
Run ./gradlew spotlessApply
to fix the formatting
Sorry for that, I was just about to push the changes you requested
Oops, I wanted to test it and ended up fixing a few things😅
Well done, by the way👏🏻
Well done, by the way👏🏻
Thank you, also for resolving the remaining formatting issues and merging it. I might look into the sulfur world generation as well.
Ok, so I'm waiting to do the release for 1.21. I was thinking of doing it today, but now I'll wait.
I might be able to finish it today, but I could use some input regarding the generation details. I've started the discussion #231 for it.
The Issue
Railcraft Reborn currently generates quarried stone using the regular
minecraft:ore
feature. I've always liked the more unique ways Railcraft used to generate resources and would thus like to see it reintroduced.The Proposal
This PR restores the classic quarried stone generation using a custom
railcraft:quarried
feature. The old generation logic has mostly been ported over and is made a bit more flexible through the use ofQuarryConfiguration
as configured feature, allowing configuration of the blocks to place (i.e.,railcraft:quarried_stone
by default) and the target blocks which are allowed to be replaced during generation (i.e., all blocks matched by the newly introduced#railcraft:quarried_replaceable_blocks
tag).Possible Side Effects
I'm not aware of any side effects except changing the generated amount of quarried stone back to its original amount which is likely lower than the amount currently generated using the
minecraft:ore
feature.Alternatives
The alternative would be to keep the status quo.