search

railmapgen / rmp

Design your own rail map by freely dragging stations from different cities and connecting them with 135-degree rounded corners or perpendicular lines!
https://railmapgen.github.io/?app=rmp
GNU General Public License v3.0
83 stars 15 forks source link

GZMTR Transfer Station Bug #326

Open 28yfang opened 1 year ago

28yfang commented 1 year ago

  1. 如视频中所示，当为二线换乘车站时箭头会消失，需刷新页面才会出现 https://github.com/railmapgen/rmp/assets/123239445/07271d64-de60-4a06-970a-66950874f6d6

  2. 如视频中所示，当为三线换乘车站时： 1) 未加颜色时箭头显示正常； 2) 加前两条线路的颜色时箭头仍为灰色； 3) 加完第三条线路的颜色后箭头会消失不见，需刷新页面才会出现 https://github.com/railmapgen/rmp/assets/123239445/610117fd-8968-4045-84ec-b2cfc6fa2393

28yfang commented 11 months ago

Update: This problem only appears in mobile.

langonginc commented 9 months ago

It appears on my Safari (Mac)

thekingofcity commented 4 months ago

Hi, I can not reproduce this on Firefox.

wongchito commented 4 months ago

@thekingofcity

I think the <path> element with marker-start marker-mid marker-end needs to be re-drawn after the related <marker> is added to the DOM. Consider a 2-step rendering or re-rendering of the station node?

This issue occurs in all WebKit browsers (Chrome, Edge, Safari), which covers over 30% of the global population.

thekingofcity commented 4 months ago

I think the <path> element with marker-start marker-mid marker-end needs to be re-drawn after the related <marker> is added to the DOM. Consider a 2-step rendering or re-rendering of the station node?

Do we have any implementation reference for this 2-step rendering? Do we need to remove and reinsert the path elements from the DOM manually? Or a simple rerender from state change is suffice?