rails-api / active_model_serializers

ActiveModel::Serializer implementation and Rails hooks
MIT License
5.32k stars 1.39k forks source link

Please update master branch and GitHub releases #2445

Closed joshgoebel closed 1 year ago

joshgoebel commented 1 year ago

@bf4 Benjamin, are you the maintainer here? I see you as the only one listed as publishing on RubyGems.

Two asks:

Screen Shot 2023-04-20 at 4 07 15 PM Screen Shot 2023-04-20 at 4 08 07 PM

Thanks, Josh

bf4 commented 1 year ago

I've never used github releases. Is that a problem? I usually release gems on RubyGems.org And the main readme does mention the maintenance state,.no?

joshgoebel commented 1 year ago

I've never used github releases. Is that a problem?

If you leave the feature on, but don't maintain it then it's pretty misleading IMHO.

Your own project literally claims your last release was in 2015.

Considering going into settings and turning it off if you don't plan to update it when you issue new releases.

And the main readme does mention the maintenance state,.no?

I wouldn't know... When I see all the files are 6-7 years old I'm probably not going to bother to read the README... (yes, I managed to miss the 3 year old readme, but that's not much better). If you're still actively maintaining the project I dunno why you wouldn't want THAT branch to be the first thing people see when coming here.

Just some easy to fix advice... you're free to take it or leave it.

bf4 commented 1 year ago

You should be nicer

joshgoebel commented 1 year ago

I pointed out two real issues that would be easy to fix; for no other reason than to help improve the project.

You asked follow up questions and I answered clearly and expediently.

That's about as nice as I can be. I'm sorry if such help isn't appreciated here. 😕