search

rails-api / active_model_serializers

ActiveModel::Serializer implementation and Rails hooks
MIT License
5.32k stars 1.39k forks source link

Re-add thread_safe gem as explicit dependency #2456

Closed mediafinger closed 8 months ago

mediafinger commented 8 months ago

Purpose

Rails 7.1 does no longer require the tread_safe gem, but AMS relies on it, which leads to error messages.

Changes

Re-adding the thread_safe gem as explicit dependency.

Caveats

None known.

Related GitHub issues

Additional helpful information

I am using the same version requirements AMS used to have. In the Rails 7.1.1 app with AMS 0.10.14 I am maintaining, thread_safe 0.3.6 has been installed.

mediafinger commented 8 months ago

Actually this issue might have only existed with the Release Candidate version of Rails. Or together with some older gem versions. Now with our app on Rails 7.1.1 and all gem dependencies updated, it does no longer produce error messages without having the thread_safe gem in the Gemfile.lock / bundle.

As I can not reproduce the situation anymore that lead to the AMS / thread_safe error messages, I will close this PR.