search

rails-engine / notifications

🛎 Notifications Center engine like GitHub or other application for any Rails applications.
MIT License
389 stars 42 forks source link

Fix #12 Unknown key `:optional` error in Rails 4.2 #15

Closed huacnlee closed 6 years ago

huacnlee commented 6 years ago

Implement way to test for Rails 4.2, 5.0, 5.1

codecov[bot] commented 6 years ago

Codecov Report

Merging #15 into master will decrease coverage by 5.1%. The diff coverage is 54.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
- Coverage   96.59%   91.48%   -5.11%     
==========================================
  Files           7        7              
  Lines          88       94       +6     
==========================================
+ Hits           85       86       +1     
- Misses          3        8       +5
Impacted Files Coverage Δ
lib/notifications/model.rb 86.11% <54.54%> (-13.89%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0ea9fff...782032f. Read the comment docs.