search

rails-engine / notifications

🛎 Notifications Center engine like GitHub or other application for any Rails applications.
MIT License
389 stars 42 forks source link

remove unnecessary file and optimize query #31

Closed SuMingXuan closed 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #31 (bfef228) into master (ba31caa) will increase coverage by 9.30%. The diff coverage is 100.00%.

:exclamation: Current head bfef228 differs from pull request most recent head 885ca10. Consider uploading reports for the commit 885ca10 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   87.50%   96.80%   +9.30%     
==========================================
  Files           8        7       -1     
  Lines         104       94      -10     
==========================================
  Hits           91       91              
+ Misses         13        3      -10
Impacted Files Coverage Δ
...trollers/notifications/notifications_controller.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ba31caa...885ca10. Read the comment docs.

SuMingXuan commented 3 years ago

关了， 想了下实例变量一定会被使用，这种算是负优化。