rails-girls-summer-of-code / rgsoc-teams

Teams management and activity
https://teams.railsgirlssummerofcode.org
MIT License
68 stars 140 forks source link

Remove newsletter checkboxes and replace by signup link #1166

Closed PandaWhisperer closed 4 years ago

PandaWhisperer commented 4 years ago

As per To-Do list. Removes the checkboxes in the "Communication" section of the edit user page and replaces them with a link to the signup page (opens in new tab/window).

Updated specs included.

Montana commented 4 years ago

Rechecked locally, used Rollbar for double check via

require File.expand_path('../application', __FILE__)
require File.expand_path('../rollbar', __FILE__)

notify = ->(e) do
  begin
    Rollbar.with_config(use_async: false) do
      Rollbar.error(e)
    end
  rescue
    Rails.logger.error "Synchronous Rollbar notification failed.  Sending async to preserve info"
    Rollbar.error(e)
  end
end
Montana commented 4 years ago

Remove newsletter checkboxes, and replace with signup link.