search

rails-girls-summer-of-code / rgsoc-teams

Teams management and activity
https://teams.railsgirlssummerofcode.org
MIT License
68 stars 140 forks source link

Testing: Verify partial doubles #906

Open carpodaster opened 6 years ago

carpodaster commented 6 years ago

Working on #905 revealed that we stub methods on objects that originally do not respond to these methods – and that's a trap! We can set verify_partial_doubles to true in spec/spec_helper.rb but that will break tests. These tests will have to be fixed.

Why is this important? See this example in the RSpec docs.

swdonovan commented 6 years ago

Hi there! I’m a first-time contributor and was hoping to help out with this issue.@dphilla & I noticed nobody was assigned to it, but if there’s already a solution in progress we're happy to try helping out elsewhere. Thanks!

emcoding commented 6 years ago

Hi @swdonovan and @dphilla ! Welcome! Great that you want to contribute. This issue is available, so, sure, give it a go!

Let us know if you get stuck. We are here to help!

emcoding commented 6 years ago

Hey @swdonovan and @dphilla. How is this PR going? Are you working on it? Can we help?

ArushiSinghal commented 6 years ago

Hello If the task is still not complete, I want to contribute to this task.

theomelo commented 4 years ago

@F3PiX @carpodaster is this fixed somehow? I would like to help if not, seems like a long time since the issue got an update