search

rails-lambda / lamby

🐑🛤 Simple Rails & AWS Lambda Integration
https://lamby.cloud
MIT License
602 stars 29 forks source link

Crypteia-Friendly Open3 Runner & Prep v4.0.2 #149

Closed metaskills closed 1 year ago

metaskills commented 1 year ago

As noted in Crypteia's issue [1] it does not support bulk environments that work around getenv(3). One drawback of that is our usage of Open3 for the runner work introduced here [2]

  1. https://github.com/customink/crypteia/issues/15
  2. https://github.com/customink/lamby/pull/93

This pull request works around the Crypteia bulk issue by being explicit with an env object using the Open3#popen3 interface which takes this as a first argument. https://docs.ruby-lang.org/en/2.0.0/Open3.html#method-i-popen3 When doing so, we simply create a new one that ensures getenv(3) is at play. I tested this in a control way in a Crypteia Codespace.

Screen Shot 2023-02-08 at 5 25 03 PM
metaskills commented 1 year ago

I have published v4.0.2 which includes this change.