search

rails-sqlserver / activerecord-sqlserver-adapter

SQL Server Adapter For Rails
MIT License
968 stars 558 forks source link

Validate table name length when renaming #1080

Closed aidanharan closed 10 months ago

aidanharan commented 10 months ago

Validate table name length when renaming. In SQL Server if you use more than 128 characters for the new name, only the first 128 characters are used and the rest is truncated.

Ref: https://learn.microsoft.com/en-us/sql/relational-databases/system-stored-procedures/sp-rename-transact-sql?view=sql-server-ver16

Fixes:

Failure:
ActiveRecord::Migration::RenameTableTest#test_rename_table_raises_for_long_table_names [/usr/local/bundle/bundler/gems/rails-7f8cdb1dc3ae/activerecord/test/cases/migration/rename_table_test.rb:58]:
ArgumentError expected but nothing was raised.

bin/rails test /usr/local/bundle/bundler/gems/rails-7f8cdb1dc3ae/activerecord/test/cases/migration/rename_table_test.rb:53