search

rails-sqlserver / activerecord-sqlserver-adapter

SQL Server Adapter For Rails
MIT License
972 stars 559 forks source link

When changing columns set date-time columns to datetime(6) by default #1089

Closed aidanharan closed 1 year ago

aidanharan commented 1 year ago

When changing columns set date-time columns to datetime(6) by default.

Fixes failing test: https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/actions/runs/6234806413/job/16922729893?pr=1088

Error:
CompatibilityTest7_0#test_datetime_sets_precision_6_on_change_table:
ActiveRecord::StatementInvalid: TinyTds::Error: Conversion failed when converting date and/or time from character string.
    activerecord-sqlserver-adapter/lib/active_record/connection_adapters/sqlserver/database_statements.rb:454:in `each'
    activerecord-sqlserver-adapter/lib/active_record/connection_adapters/sqlserver/database_statements.rb:454:in `handle_to_names_and_values_dblib'