rails-sqlserver / activerecord-sqlserver-adapter

SQL Server Adapter For Rails
MIT License
968 stars 558 forks source link

Fix the invalid options migration tests #1095

Closed aidanharan closed 9 months ago

aidanharan commented 9 months ago

Fix the test/cases/migration/invalid_options_test.rb tests.

https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/actions/runs/6300135339/job/17102280466?pr=1094

ActiveRecord::Migration::InvalidOptionsTest#test_add_reference_with_invalid_options [/usr/local/bundle/bundler/gems/rails-6797c7382e37/activerecord/test/cases/migration/invalid_options_test.rb:46]:
--- expected
+++ actual
@@ -1 +1 @@
-"Unknown key: :boring_key. Valid keys are: :limit, :precision, :scale, :default, :null, :collation, :comment, :primary_key, :if_exists, :if_not_exists"
+"Unknown key: :boring_key. Valid keys are: :limit, :precision, :scale, :default, :null, :collation, :comment, :primary_key, :if_exists, :if_not_exists, :is_identity"

bin/rails test /usr/local/bundle/bundler/gems/rails-6797c7382e37/activerecord/test/cases/migration/invalid_options_test.rb:39

F

Failure:
ActiveRecord::Migration::InvalidOptionsTest#test_add_column_with_invalid_options [/usr/local/bundle/bundler/gems/rails-6797c7382e37/activerecord/test/cases/migration/invalid_options_test.rb:68]:
--- expected
+++ actual
@@ -1 +1 @@
-"Unknown key: :preccision. Valid keys are: :limit, :precision, :scale, :default, :null, :collation, :comment, :primary_key, :if_exists, :if_not_exists"
+"Unknown key: :preccision. Valid keys are: :limit, :precision, :scale, :default, :null, :collation, :comment, :primary_key, :if_exists, :if_not_exists, :is_identity"

bin/rails test /usr/local/bundle/bundler/gems/rails-6797c7382e37/activerecord/test/cases/migration/invalid_options_test.rb:63