search

rails-sqlserver / activerecord-sqlserver-adapter

SQL Server Adapter For Rails
MIT License
968 stars 558 forks source link

Fix update-all for composite key #1189

Closed aidanharan closed 3 weeks ago

aidanharan commented 1 month ago

Fix:

https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/actions/runs/9229223643/job/25394973176

1) Error:
UpdateAllTest#test_update_all_composite_model_with_join_subquery:
ActiveRecord::StatementInvalid: TinyTds::Error: An expression of non-boolean type specified in a context where a condition is expected, near ','.
    lib/active_record/connection_adapters/sqlserver/database_statements.rb:440:in `each'

  3) Error:
DeleteAllTest#test_delete_all_composite_model_with_join_subquery:
ActiveRecord::StatementInvalid: TinyTds::Error: An expression of non-boolean type specified in a context where a condition is expected, near ','.
    lib/active_record/connection_adapters/sqlserver/database_statements.rb:440:in `each'
    lib/active_record/connection_adapters/sqlserver/database_statements.rb:440:in `handle_to_names_and_values'

Related: https://github.com/rails/rails/pull/49655