search

rails-sqlserver / activerecord-sqlserver-adapter

SQL Server Adapter For Rails
MIT License
974 stars 563 forks source link

Allow INSERT statements with SELECT notation #1238

Closed zurchpet closed 1 month ago

zurchpet commented 1 month ago

This Pull request fixes #1237

aidanharan commented 1 month ago

@zurchpet The CI tests are failing. Tests will need to pass before I can merge the PR.

The failing ActiveRecord::PredicateBuilderTest tests can be ignored as they have already been fixed in main by https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/1239

aidanharan commented 1 month ago

@zurchpet Thanks for the PR. Do you need the change back ported to version 7.2?

zurchpet commented 1 month ago

@aidanharan Thanks a lot! Yes. Also in 7.1 actually. We pin to version 7.1.4 for now. Rails 7.2 or Rails 8.0 Upgrade is still in planing.