search

rails-sqlserver / activerecord-sqlserver-adapter

SQL Server Adapter For Rails
MIT License
974 stars 563 forks source link

Fix queries with date and date-time placeholder conditions #1246

Closed andsip closed 1 month ago

andsip commented 1 month ago

Fix queries with date and date-time placeholder conditions such as:

where("written_on < ?", Date.today)
where("written_on < ?", DateTime.current)

This should fix #1243.

aidanharan commented 1 month ago

Could you add a few tests and update the CHANGELOG?

andsip commented 1 month ago

I don't see any tests that have been added in the last several changes in this code part.. Could you point me to the test file, where similar functionality is being tested already?