rails-sqlserver / activerecord-sqlserver-adapter

SQL Server Adapter For Rails
MIT License
973 stars 561 forks source link

ODBC support? #682

Open smlsml opened 5 years ago

smlsml commented 5 years ago

We have a Rails application that runs on-premise in Windows VDI environments where SQL Server is always the DB of choice. We'd like to upgrade from Rails 4 to 5, but have noticed that ODBC support was removed from this adapter.

Emulating all the capabilities provided by ODBC in Windows with TDS (like secure and validated TLS connections, mirroring support, debug logs, etc, etc, etc) is a huge task. It also requires that we put passwords and other config in database.yml yada yada.

Was ODBC support removed solely because it wasn't being testing or were there other major changes and problems introduced by Rails 5? We will likely fork this gem and attempt to add it back, perhaps we can provide the necessary testing (if that's all it is) to get it back in here.

Another concern is now that the mode has been removed, I'm worried other changes have been made that are TDS biased. Any additional information is welcome. Thanks!

wpolicarpo commented 5 years ago

@metaskills can I ask you some background on why ODBC was removed?

ryanvz commented 4 years ago

Is there any plan to add back ODBC support? Microsoft supplies a multiplatform ODBC driver which supports, for example, Multi-Subnet failover, which FreeTDS does not seem to natively support.

smlsml commented 4 years ago

Is there any plan to add back ODBC support? Microsoft supplies a multiplatform ODBC driver which supports, for example, Multi-Subnet failover, which FreeTDS does not seem to natively support.

We've forked this gem and added ODBC support back to it. So far it has been easy to keep up with the incoming changes. It's in a private repository but I can confirm it works and hasn't been too large of a hassle to maintain.

wpolicarpo commented 4 years ago

@smlsml any chance you would want to add ODBC support to this gem again? I am open to it and could possibly help with PRs.