search

rails-sqlserver / tiny_tds

TinyTDS - Simple and fast FreeTDS bindings for Ruby using DB-Library.
Other
607 stars 189 forks source link

Update cross build, Travis and Appveyor-CI #456

Closed larskanis closed 4 years ago

larskanis commented 4 years ago

This PR includes #455 . It adds ruby versions 2.6 and 2.7 to Windows binary gems and updates and fixes Appveyor and Travis CI. It also adds ruby-head to Appveyor-CI. It removes rubies before 2.4 and some necessary workarounds. OpenSSL and FreeTDS are updated to the latest release versions.

Appveyor needs to be re-enabled for this repository to be effective.

aharpervc commented 4 years ago

This seems fine with me to merge

larskanis commented 4 years ago

@aharpervc Can you merge this? You should have the permission to do so. However you don't seem to have permissions to release tiny_tds on rubygems.org. @metaskills Could you add @aharpervc to rubygems.org? Any other opinions?

metaskills commented 4 years ago

@metaskills Could you add @aharpervc to rubygems.org? Any other opinions?

I can add anyone needed to ruby gems. I just need their email address. You can DM this on Twitter (same metaskills user name) if y'all want or obfuscate it here too.

aharpervc commented 4 years ago

@aharpervc Can you merge this? You should have the permission to do so.

Happy to, although I assumed you could as well since you're listed as a member?

I can add anyone needed to ruby gems. I just need their email address. You can DM this on Twitter (same metaskills user name) if y'all want or obfuscate it here too.

I just emailed you

larskanis commented 4 years ago

Happy to, although I assumed you could as well since you're listed as a member?

Sure, but I'd like to stay a contributor only and don't want to maintain a project, that I use rarely. I'm glad if you could do maintenance, if Ken doesn't have the time to.

metaskills commented 4 years ago

The only thing I have time for is to help others adopt and service this project. Just point me to who needs perms and where :)

aharpervc commented 4 years ago

Well I expected appveyor to run the job when I merged this PR, but it doesn't look like that happened: https://ci.appveyor.com/project/rails-sqlserver/tiny-tds/history

Something might need to get turned on over there, but if so I don't have access

metaskills commented 4 years ago

I approved the Appveyor addition. Let me know if I can do anything else.

aharpervc commented 4 years ago

Looks like something is missing as I am still not seeing a new version on https://rubygems.org/gems/tiny_tds/versions or is there a delay before it shows up @aharpervc ?

No new version has been published yet, because no new version has been prepared yet, because appveyor isn't running the tests yet, because of some unknown reason. I hope to be able to revisit that question this week.

larskanis commented 4 years ago

I just added #459, but Appveyor is still not running on the repository. @metaskills , @aharpervc Did you add tiny_tds as new project here? https://ci.appveyor.com/projects/new

aharpervc commented 4 years ago

No, but that may be due to a problem on my end... Appveyor wants to "Authorize as GitHub App" or "Authorize as OAuth App", and I'm not sure what the implications are for this org/repo. Which one did you pick?

larskanis commented 4 years ago

@aharpervc I think "Authorize as GitHub App".

aharpervc commented 4 years ago

@aharpervc I think "Authorize as GitHub App".

Alright, I gave that a try. It looks like the request will need to be approved by a rails-sqlserver org admin

metaskills commented 4 years ago

I think I just authorized that.

aharpervc commented 4 years ago

Thanks, I tried to complete the process by adding Appveyor to this repo, but then I got an error saying it can only be done by an org owner:

image

metaskills commented 4 years ago

OK, I just invited you as an admin to our Appveyor account. From there you can authorize it via your account. Reminder, Microsoft still pays for this account too and it looks like the CC is valid till 2021 too.

Screen Shot 2020-03-06 at 7 05 57 AM
aharpervc commented 4 years ago

Thanks, I can now see the tiny_tds project.

From the events log it seems that appveyor was notified when this PR was merged to master, but declined to run the job due to not finding appveyor.yml (which is odd because it definitely is right there).

image

I suspect appveyor might be looking at an outdated version of the repo, because when I tried to just have it run a build manually, I got this error:

image

I'm not sure what credentials it might be trying, so I returned to the authorizations page here: https://ci.appveyor.com/account/rails-sqlserver/authorizations and tried to run "Authorize as GitHub App" as described above, but again got the error This action must be performed by an organization owner.

@metaskills I think you might need to click that install button in appveyor to get it to reconnect to this repo, can you review that when you have a moment?

metaskills commented 4 years ago

Thanks, we are getting close. I did not want to click it because it would get access to Custom Ink's account too. So I just changed you to an org owner too.

metaskills commented 4 years ago

@wpolicarpo Just made you an org owner as well.

aharpervc commented 4 years ago

Alright I was able to start the build manually, and it grabbed the latest code from master and is building right now.

MadsNielsen commented 4 years ago

Same. We're also depending heavily on this gem. @aharpervc

aae42 commented 4 years ago

is anyone still working on this? so close!

aharpervc commented 4 years ago

I will revisit this and try to cut a new release this week or next week, if I can

vifrac commented 4 years ago

I will revisit this and try to cut a new release this week or next week, if I can

Hey, very thanks for your work, I too wait for this update

Reppinger commented 4 years ago

Thanks to all who contributed. I will temporarily roll back to ruby 2.5 which causes me no problems right now. Looking forward to going back to 2.6. Thanks, @aharpervc !

ecentell-CPF commented 4 years ago

Thank you for #462 and i can see it up on https://rubygems.org/gems/tiny_tds/versions/2.1.3.pre-x64-mingw32 !

aharpervc commented 3 years ago

It took awhile, but 2.1.3 has now been released