Closed aharpervc closed 3 years ago
Welp it looks like at least Travis is rebuilding master every time I push to this branch, which is super lame, so I guess I'll look at that configuration now.
I have pushed 2.1.3-pre
to rubygems for testing
I will move the openssl change out of this branch before merging. If nobody has any other objections I will try to merge & push v2.1.3 final next week.
Thanks for the nudge to report! We tested 2.1.3-pre with ruby 2.5.5 and 2.6.5 and rails 5.2.4.2 at work and we are all green. (Not that this tells you much, but I suppose it's better than nothing)
On Fri, Apr 17, 2020 at 10:23 AM Andrew Harper notifications@github.com wrote:
I will move the openssl change out of this branch before merging. If nobody has any other objections I will try to merge & push v2.1.3 final next week.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rails-sqlserver/tiny_tds/pull/462#issuecomment-615368296, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVOPMOFV6KV5SSSD3VOY5DRNCGAZANCNFSM4MED4L3Q .
Do you know when v2.1.3 final might be pushed? Thanks!
The next step is to slice out that openssl url change to a separate PR, get that merged, then rebase this branch & remove the -pre
. Then it can be merged, and then I can build & push the gems.
e: actually, I just tried it again and the original openssl url is now working. Maybe the former was a temporary failure? I'll revert that change and see what happens.
e2: now blocked on figuring out what's going on here https://github.com/rails-sqlserver/tiny_tds/issues/465
Can you provide an update @aharpervc thanks!
Can you provide an update @aharpervc thanks!
The current status is that this is blocked on https://github.com/rails-sqlserver/tiny_tds/issues/465, as I said. I don't want to ship a broken gem, so figuring out what is going on there is a prerequisite for shipping. Anyone can contribute to that investigation, so if getting 2.1.3 deployed is a priority for you, then any assistance you can provide to resolving the blocking issue will help make that happen.
I foolishly published the Linux version to rubygems before building the Windows version, but of course now I'm having a problem building it 🤦♂️. I am investigating, and hopefully all versions will be published soon
For posterity, this is the current error:
That's a new one for me...
This is almost certainly a path problem when building from Windows hosts, but with help from @bvogelzang all copies are now pushed to rubygems
Now, need to remember how to build & push these gems correctly.
This will close https://github.com/rails-sqlserver/tiny_tds/issues/458 & https://github.com/rails-sqlserver/tiny_tds/issues/434 when I merge & push the final release