Prepare for 2.1.4 - Githubissues

rails-sqlserver / tiny_tds

TinyTDS - Simple and fast FreeTDS bindings for Ruby using DB-Library.

Other

606 stars 190 forks source link

Prepare for 2.1.4 #486

Closed aharpervc closed 3 years ago

aharpervc commented 3 years ago

todo

[x] public prerelease incorporating these with assistance from @bvogelzang & co
[x] get feedback on this prerelease and/or those PR's
[x] merge the PR's
[x] update the changelog here
[x] update to 2.1.4 final here
[x] merge this PR
[x] public release

aharpervc commented 3 years ago

Updated to pre2 with the false fix, cc @bvogelzang @wpolicarpo. One of us will cut a new release shortly. BTW I took the liberty of squashing your PR's down to a single commit just for this preview branch only; each one can merge to master with whatever is the appropriate number of commits.

swatosh commented 3 years ago

Would it be possible to update the embedded version of OpenSSL in the mingw32 versions before the official release? Thanks!

(If not, is it as simple as overwriting the dlls and exe in the bin folder? Or are there instructions somewhere that I failed to find?)

For the silent majority: Thank you for this gem, it's been fantastic!

aharpervc commented 3 years ago

Would it be possible to update the embedded version of OpenSSL in the mingw32 versions before the official release? Thanks!

(If not, is it as simple as overwriting the dlls and exe in the bin folder? Or are there instructions somewhere that I failed to find?)

For the silent majority: Thank you for this gem, it's been fantastic!

My preference is to avoid anything else that would extend the timeframe for getting this release out. We can always cut a new version with new changes once they are all approved.

Is something broken with OpenSSL right now? Is there already an issue or PR tracking this request? (If not, can you make it?)

swatosh commented 3 years ago

Would it be possible to update the embedded version of OpenSSL in the mingw32 versions before the official release? Thanks! (If not, is it as simple as overwriting the dlls and exe in the bin folder? Or are there instructions somewhere that I failed to find?) For the silent majority: Thank you for this gem, it's been fantastic!

My preference is to avoid anything else that would extend the timeframe for getting this release out. We can always cut a new version with new changes once they are all approved.

Is something broken with OpenSSL right now? Is there already an issue or PR tracking this request? (If not, can you make it?)

There are two CVEs in OpenSSL 1.1.1j that our security folks are on about. No PR that I know of. I can try, but I don't really have any kind of development environment, so it'll be iffy.

swatosh commented 3 years ago

Would it be possible to update the embedded version of OpenSSL in the mingw32 versions before the official release? Thanks! (If not, is it as simple as overwriting the dlls and exe in the bin folder? Or are there instructions somewhere that I failed to find?) For the silent majority: Thank you for this gem, it's been fantastic!

My preference is to avoid anything else that would extend the timeframe for getting this release out. We can always cut a new version with new changes once they are all approved. Is something broken with OpenSSL right now? Is there already an issue or PR tracking this request? (If not, can you make it?)

There are two CVEs in OpenSSL 1.1.1j that our security folks are on about. No PR that I know of. I can try, but I don't really have any kind of development environment, so it'll be iffy.

So I created a PR. Seems trivial, but as I mentioned, I don't really have a development environment. Hope it's near what's needed