rails-sqlserver / tiny_tds

TinyTDS - Simple and fast FreeTDS bindings for Ruby using DB-Library.
Other
606 stars 189 forks source link

Support Ruby 3.0 #524

Closed andyundso closed 1 year ago

andyundso commented 1 year ago

This PR adds support for Ruby 3.0. It needed a couple of changes, including a few that are technically for Ruby 2.5 support.

I tested the changes against a project of mine. It's a "traditional" Rails v6.1 application using 6.1.2.1. I ran our CI with a version of the gem build based on my changes and everything is green with the following combinations:

Credits to @bryanwieg for the initial work in #521.

bryanwieg commented 1 year ago

@andyundso this looks really nice!

@aharpervc will probably be the one to review it.

aharpervc commented 1 year ago

This is cool... very exciting. Are you able to also do any of the suggestions here? At least having build artifacts for this would be great to get more people for testing.

andreasnef commented 1 year ago

Would be great to get this as I assume many (as us) are planning moving to v3 soon.

orgads commented 1 year ago

Please add also 3.1 and 3.2.

andyundso commented 1 year ago

As long as things are still moving here, I created a fork with support for Ruby 3.0, 3.1 and 3.2, including a fat gem for Windows.

orgads commented 1 year ago

Thank you!

andyundso commented 1 year ago

Replaced with #530.