search

rails-sqlserver / tiny_tds

TinyTDS - Simple and fast FreeTDS bindings for Ruby using DB-Library.
Other
607 stars 189 forks source link

Prepare for 2.1.6 #540

Closed ecentell-CPF closed 10 months ago

ecentell-CPF commented 1 year ago

Prepare for 2.1.6

ecentell-CPF commented 11 months ago

Looks like the artifact issue is fixed via PR #541 which was mentioned as a prerequisite (#533 ) to this PR. Can we move ahead @aharpervc @andyundso

andyundso commented 11 months ago

I would leave this PR to @aharpervc , as he has ultimately permissions to publish a new gem version. but the PR itself looks good to me.

ecentell-CPF commented 10 months ago

Hello @aharpervc any chance to look into this?

aharpervc commented 10 months ago

Yeah, seems fine to me. I don't see the gem files on the artifacts page in CircleCI, though. It seems prudent to push 2.1.6.pre to rubygems before merging this branch. Thoughts?

ecentell-CPF commented 10 months ago

@andyundso can you comment on the disposition of the artifacts? I second the approach of getting the push to rubygems so I can test that side of the equation.

andyundso commented 10 months ago

Three things.

First, I think I never added artifact upload for the "plain" gem, like used in the Linux tests, only the platform-specific versions from Windows.

Second, CircleCI appears to delete artifacts after 30 days.

After 30 days, all artifacts associated with a build automatically expire. Since this run is over 30 days old, the artifacts may have been deleted.

I just re-run the pipeline on the master branch, and there the artifacts appear again, e.g. here.

Third, your branch is behind, so even if you re-run your build, the Windows artifacts will not appear as the fix from #541 is not included.

ecentell-CPF commented 10 months ago

Thank you for pointing out the branch needing a refresh, I have finished the re sync.

ecentell-CPF commented 10 months ago

@aharpervc I see the artifacts for the windows gems in Circle now, can you verify on your side?

(edited for clarity)

ecentell-CPF commented 10 months ago

Hello @aharpervc any chance to look into this?

andyundso commented 10 months ago

@ecentell-CPF I will do some final tests until Tuesday and then release 2.1.6 to RubyGems.