search

rails-sqlserver / tiny_tds

TinyTDS - Simple and fast FreeTDS bindings for Ruby using DB-Library.
Other
605 stars 191 forks source link

Fix path to artifacts #541

Closed andyundso closed 9 months ago

andyundso commented 9 months ago

As I parallelized the cross-compilation process, the gems were moved into another folder dedicated to their target platform during the build. This change was not reflected when storing the artifacts.

aharpervc commented 9 months ago

I don't see anything on the artifacts tab here, should that be showing something now? https://app.circleci.com/pipelines/github/andyundso/tiny_tds/2/workflows/e920c589-ee26-4afd-ba5c-fd10bd257931/jobs/35/artifacts

andyundso commented 9 months ago

The artifacts are available from the cross compile jobs:

But can also upload them from each Windows test, if this is your prefered solution.

aharpervc commented 9 months ago

I see. That sort of makes sense, although I'm concerned about accessibility. How I checked was I scrolled to the bottom of this PR, clicked "show all checks", clicked into the details for "windows-2.4", clicked artifacts, and didn't see anything.

I think it'd be great if repo visitors had quick access to the fat gems for whichever version of ruby they're using, quickly from each PR.

Thoughts?

andyundso commented 9 months ago

generally agree with you.

I would keep the artifacts upload on the precompile step, as the x86 version is not used in any test. But additionally, upload the artifact from each test, so people can get the correct version for their system, as suggest by you.

will take care of this tomorrow and amend the PR.

andyundso commented 9 months ago

@aharpervc took a while longer, had couple of other things to do first.

but as discussed, now each test on windows uploads the version it has tested as an artifact. would you mind to re-review?