Mark `alloc` as undefined for `TinyTds::Result`

rails-sqlserver / tiny_tds

TinyTDS - Simple and fast FreeTDS bindings for Ruby using DB-Library.

Other

605 stars 191 forks source link

Mark `alloc` as undefined for `TinyTds::Result` #542

Closed andyundso closed 9 months ago

andyundso commented 9 months ago

From my understanding, you only need to define an alloc function if you want to define a C struct and store values on it. For example, TinyTds::Client defines such an allocate function to wrap its client. On TinyTds::Result, it does not seem we do have a struct and therefore does not need an alloc function.

Closes #515

aharpervc commented 9 months ago

I assume that the warning from https://github.com/rails-sqlserver/tiny_tds/issues/515 is no longer showing with this?

andyundso commented 9 months ago

Exactly. You can compare the output on the Ruby 3.2 job on the current master and this branch, and you see that the warning no longer shows on the very top of the output.

Michoels commented 9 months ago

Looks great! When will this be released?

taylorthurlow commented 6 months ago

Looks great! When will this be released?

This looks like it went out with v2.1.6 in early December.