search

rails / actionpack-action_caching

Action caching for Action Pack (removed from core in Rails 4.0)
MIT License
262 stars 96 forks source link

Fix #43 html escaping when layout is false #48

Closed antulik closed 6 years ago

antulik commented 7 years ago

Fixes #43. Same as PR #42 but fixes the cause of the problem.

From rails docs:

When using html: option, HTML entities will be escaped if the string is not marked as HTML safe by using html_safe method.

jomo commented 7 years ago

Can confirm this works, tested using

gem 'actionpack-action_caching', github: 'antulik/actionpack-action_caching', ref: '8c6e52c69315d67437f480da5dce4b7c8737fb32'
rafaelcgo commented 6 years ago

Hade the same issue. Hope this gets merged.

stephanpavlovic commented 6 years ago

Me too, any reason this doesn't get merged?

rafaelfranca commented 6 years ago

It is missing tests.

antulik commented 6 years ago

@rafaelfranca updated the tests. Existing tests already test everything, it's just html code doesn't include any html symbols, so fixed that.