search

rails / activejob

Declare job classes that can be run by a variety of queueing backends
743 stars 47 forks source link

Deep serialization #79

Closed cristianbica closed 10 years ago

DouweM commented 10 years ago

If we're gonna do this, we should do deep deserialization as well for global IDs.

cristianbica commented 10 years ago

If we're gonna do this, we should do deep deserialization as well for global IDs.

what do you mean by that?

DouweM commented 10 years ago 
before = [Person.find(1), Person.find(2), Person.find(3)]
after = Arguments.deserialize(Arguments.serialize(before))

before should be equal to after, but is now just an array of three string global IDs. .deserialize should be adapted to do deep deserialization, in line with .serialize's deep serialization.

cristianbica commented 10 years ago

Got it. Working on it

cristianbica commented 10 years ago

done with the hash values

DouweM commented 10 years ago

Looks good to me!