[WIP] Threaded inline adapter

rails / activejob

Declare job classes that can be run by a variety of queueing backends

743 stars 47 forks source link

[WIP] Threaded inline adapter #81

Closed seuros closed 10 years ago

seuros commented 10 years ago

ref #76 , #80 cc/ @rosenfeld, @cristianbica, @dhh

rosenfeld commented 10 years ago

I was trying locally after cherry-picking your last commit in your repo but I'm trying to figure out how to add specific tests for some adapter... I can't find any examples so far...

seuros commented 10 years ago

Well , we could do skip if ActiveJob::Base.queue_adapter == :inline_threaded but i don't like this.

rosenfeld commented 10 years ago

I'd prefer to use a separte file for specific adapter tests. But I couldn't find where scheduled_at is tested for the inline adapter for instance... So I'm not sure what conventions to use...

rosenfeld commented 10 years ago

The tests after cherry-picking passed here, but they don't test anything useful for the InlineThreaded adapter for instance...

seuros commented 10 years ago

scheduled_at ? you mean enqueue_at

rosenfeld commented 10 years ago

Yes, sorry for the confusion. This test is for the generic interface and it will not test the inline adapter, right? For example, it doesn't ensure that the job was indeed run.