Have .queue_as only set queue name for job in question.

rails / activejob

Declare job classes that can be run by a variety of queueing backends

743 stars 47 forks source link

Have .queue_as only set queue name for job in question. #85

Closed DouweM closed 10 years ago

DouweM commented 10 years ago

Fixes #84.

dhh commented 10 years ago

I don't understand why we need to split this out? Why have the queue name be part of queueing? This doesn't look like an improvement in structure to be, not withstanding that it fixes the bug.

DouweM commented 10 years ago

You're right. I made some incorrect assumptions about include and extend that made this setup necessary in my head. I've refactored it to host everything in the QueueName module.

dhh commented 10 years ago

All good :+1:

DouweM commented 10 years ago

Cool. Is there a specific reason #78 and #83 haven't been merged yet?

dhh commented 10 years ago

Merged #83, added a comment about #78.

On Jun 12, 2014, at 12:17 PM, Douwe Maan notifications@github.com wrote:

Cool. Is there a specific reason #78 and #83 haven't been merged yet?

— Reply to this email directly or view it on GitHub.

DouweM commented 10 years ago

:+1: