Closed felixbuenemann closed 8 years ago
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @tenderlove (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.
@rafaelfranca Do you mind taking a look? Seems @tenderlove is busy.
Code looks good but could you change the test syntax to use assert
?
@rafaelfranca Updated to use assert/refute syntax and rebased on master.
@felixbuenemann may want to just kick this. it looks like it should work
Seems Travis CI fixed the bundler problem, so I removed the fix and rebased on current master. (Deleted comments regarding unrelated Travis CI failures on jruby-head.)
Love it! Thanks :smile:
This implements the simple and extended variant of the SQL CASE conditional:
Both variants are supported by at least PostgreSQL, MySQL, SQLite and Oracle.
This resolves #168 and is based on original code from acts_as_ordered_tree. I've asked @take-five for permission and license of the code in take-five/acts_as_ordered_tree#34.
I'm not familiar with the arel code base, so please check if there are enough tests and if my usage of
build_quoted
is OK (using the node's api without it felt weird).