Closed yui-knk closed 8 years ago
Ruby 2.4 unifies Fixnum and Bignum into Integer: https://bugs.ruby-lang.org/issues/12005
Ruby ~2.3 1234.class is Fixnum and 123456789012345678901234567890.class is Bignum. Ruby 2.4+ 1234.class is Integer and 123456789012345678901234567890.class is Integer.
1234.class
Fixnum
123456789012345678901234567890.class
Bignum
Integer
So what we should do is defining visit_Integer method to visitors.
visit_Integer
r? @sgrif
(@rails-bot has picked a reviewer for you, use r? to override)
cc @jeremy
Do we also want to restrict support for visit_Bignum and visit_Fixnum for < 2.4 ?
No, I think it's fine to leave them as-is
Ruby 2.4 unifies Fixnum and Bignum into Integer: https://bugs.ruby-lang.org/issues/12005
Ruby ~2.3
1234.class
isFixnum
and123456789012345678901234567890.class
isBignum
. Ruby 2.4+1234.class
isInteger
and123456789012345678901234567890.class
isInteger
.So what we should do is defining
visit_Integer
method to visitors.