Closed koic closed 8 years ago
Ruby 2.4 unifies Fixnum and Bignum into Integer: https://bugs.ruby-lang.org/issues/12005
Ruby ~2.3 1234.class is Fixnum and 123456789012345678901234567890.class is Bignum. Ruby 2.4+ 1234.class is Integer and 123456789012345678901234567890.class is Integer.
1234.class
Fixnum
123456789012345678901234567890.class
Bignum
Integer
So what we should do is defining visit_Integer method to visitors.
visit_Integer
Backport of https://github.com/rails/arel/commit/dc85a6e9c74942945ad696f5da4d82490a85b865
LGTM
vipulnsward
commented
8 years ago
Ruby 2.4 unifies Fixnum and Bignum into Integer: https://bugs.ruby-lang.org/issues/12005
Ruby ~2.3
1234.classisFixnumand123456789012345678901234567890.classisBignum. Ruby 2.4+1234.classisIntegerand123456789012345678901234567890.classisInteger.So what we should do is defining
visit_Integermethod to visitors.Backport of https://github.com/rails/arel/commit/dc85a6e9c74942945ad696f5da4d82490a85b865