search

rails / arel

A Relational Algebra
2.06k stars 390 forks source link

Adds UNION DISTINCT functionality #442

Closed nickfarina closed 8 years ago

nickfarina commented 8 years ago

Adds functionality to specify UNION DISTINCT on a UNION. I arrived at the fix by following the pattern for UNION ALL

rails-bot commented 8 years ago

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @sgrif (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

matthewd commented 8 years ago

To what end? Isn't this just a non-standard spelling of an ordinary UNION?

nickfarina commented 8 years ago

Great point, this is not necessary.