search

rails / arel

A Relational Algebra
2.06k stars 390 forks source link

remove union mapping as :binary node when performing DepthFirst enumeration #443

Closed mgbatchelor closed 7 years ago

mgbatchelor commented 8 years ago

When using an in statement on a union a lot of garbage ends up in the generated SQL. There might be a chance that this line was not suppose to be checked in during this commit. A reason I lean that way was another Union related change that was quickly removed after that commit here

cc @tenderlove maybe you have some more insights about this?

rails-bot commented 8 years ago

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

rafaelfranca commented 7 years ago

Backported in 9bfe504