search

rails / arel

A Relational Algebra
2.06k stars 390 forks source link

Fix invalid BindParam output in Dot visitor #444

Closed alassek closed 8 years ago

alassek commented 8 years ago

Since BindParam has no value, treating it like a string causes it to fallback to Object#to_s, leading to output like #<Arel::Nodes::BindParam:0x007fa43c866108>.

Since angle brackets are significant in Dot labels, this causes Error: bad label format when passing the graph into dot.

I've changed visit_Arel_Nodes_BindParam to a noop, which solves the problem.

rails-bot commented 8 years ago

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @tenderlove (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

rafaelfranca commented 7 years ago

Backported in ec055cd