search

rails / arel

A Relational Algebra
2.06k stars 390 forks source link

use #data_source_exists? if possible instead of deprecated #table_exi… #446

Closed abonec closed 8 years ago

abonec commented 8 years ago

Using of arel raise DEPRECATION WARNING: table_exists? is deprecated and will be removed from Rails 5.1 (use #data_source_exists? instead) in our project with rails 5.0.0.1

rails-bot commented 8 years ago

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

abonec commented 8 years ago

https://github.com/rails/rails/blob/8c402ef425771c3dbb4659dd946714e69fdf5ce9/activerecord/lib/active_record/connection_adapters/postgresql/schema_statements.rb#L99

michaldarda commented 8 years ago

👍 good job

michaldarda commented 8 years ago

@rafaelfranca any chance this will be merged soon?

abonec commented 8 years ago

Changed and rebased with the current master.

rafaelfranca commented 8 years ago

Backported in 49b32da

rafaelfranca commented 8 years ago

Released in 7.1.4