added math to function nodes

rails / arel

A Relational Algebra

2.06k stars 390 forks source link

added math to function nodes #455

Closed romankonz closed 6 years ago

kbrock commented 6 years ago

@romankonz have you tested after https://github.com/rails/arel/pull/449 was merged?

Wonder if it just works now

nikolai-b commented 6 years ago

@kbrock Just tested the SUM (as math was explicitly added to count 1aeefa68) At 5f25b0a it errors with

Error:
Arel::Nodes::Sum::math#test_0001_should be able to use math operators:
NoMethodError: undefined method `-' for #<Arel::Nodes::Avg:0x0055f182205b10>
    ./arel/test/nodes/test_sum.rb:38:in `block (3 levels) in <top (required)>'

and after #449 (i.e. aa11ad91) it passes.

kbrock commented 6 years ago

@nikolai-b thanks

Curious if count node still needs Math mixed in. but oh well. glad it was working for you

matthewd commented 6 years ago

Per #523, Arel development is moving to rails/rails.

If this PR is still relevant, please consider reopening it over there.