rails / arel

A Relational Algebra
2.06k stars 390 forks source link

Address `Use assert_nil if expecting nil` warnings #463

Closed yahonda closed 7 years ago

yahonda commented 7 years ago

This pull request suppresses Use assert_nil if expecting nil warnings.

Environment

Steps to reproduce:

$ bundle exec ruby -w -I"lib:lib:test" test/test_select_manager.rb
Run options: --seed 11993

# Running:

.........................................................Use assert_nil if expecting nil from /home/yahonda/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/gems/minitest-5.10.1/lib/minitest/spec.rb:23:in `must_equal'. This will fail in MT6.
................................................Use assert_nil if expecting nil from /home/yahonda/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/gems/minitest-5.10.1/lib/minitest/spec.rb:23:in `must_equal'. This will fail in MT6.
.......

Finished in 0.048920s, 2289.4336 runs/s, 2820.9093 assertions/s.

112 runs, 138 assertions, 0 failures, 0 errors, 0 skips
$
rails-bot commented 7 years ago

r? @tenderlove

(@rails-bot has picked a reviewer for you, use r? to override)

yahonda commented 7 years ago

Thanks for the useful information. Updated to use must_be_nil and squashed.

kaspth commented 7 years ago

Thanks!