search

rails / arel

A Relational Algebra
2.06k stars 390 forks source link

named functions compared to nil #470

Closed kmmndr closed 7 years ago

kmmndr commented 7 years ago

Using Arel v6.0.4 Testing equality on named function produce wrong SQL code if tested value is nil.

Nodes::NamedFunction.new('omg', [Arel.star]).eq(nil) => omg(*) = NULL

On master branch, there is no problem with named functions since nil? has been overridden...

rails-bot commented 7 years ago

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @tenderlove (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.