search

rails / arel

A Relational Algebra
2.06k stars 390 forks source link

Lateral expressions for PostgreSQL #481

Closed lautis closed 6 years ago

lautis commented 7 years ago

Support for PostgreSQL lateral expressions. This is treated as an unary function applied to a query expression.

Lateral is a separate function to provide interoperability with aliases and unions. These are also separate node types that wrap SelectStatements. The lateral option would need to be implemented in these nodes separately if lateral was an option of SelectStatement.

When building the query, an alias can be given as an argument. This enables building a lateral query with an table alias without using either Nodes::TableAlias or Nodes::Lateral directly.

Fixes #382.

rails-bot commented 7 years ago

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

eric-pigeon commented 7 years ago

@rafaelfranca any chance this will get merged?