search

rails / arel

A Relational Algebra
2.06k stars 390 forks source link

Remove encoding utf-8 magic comment #494

Closed koic closed 7 years ago

koic commented 7 years ago

Summary

The default script encoding from Ruby 2.0 is UTF-8.

https://bugs.ruby-lang.org/issues/6679

There are unnecessary # encoding: utf-8 magic comment. AFAIK, Arel is currently tested Ruby 2.0.0 or higher on Travis CI. This PR removes magic comment.

Other Information

The following commit has been removed Ruby 1.9 support.

https://github.com/rails/arel/commit/f1a3421ce7083181ebd463c8147c2d4b95539ca8

rails-bot commented 7 years ago

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

matthewd commented 7 years ago

We should really be setting a minimum ruby version in the gemspec, but I think this is fine to merge anyway. At a glance, neither of these files even have encoding-relevant strings in them.

koic commented 7 years ago

Thanks for your comment. I opened PR about it.

495.