search

rails / arel

A Relational Algebra
2.06k stars 390 forks source link

Add required_ruby_version to gemspec #495

Closed koic closed 7 years ago

koic commented 7 years ago

Follow up of https://github.com/rails/arel/pull/494#issuecomment-321524575.

Arel tested Ruby 2.0.0 or higher with Travis CI, so I wrote that version to required_ruby_version.

rails-bot commented 7 years ago

r? @rafaelfranca

(@rails-bot has picked a reviewer for you, use r? to override)

yahonda commented 7 years ago

I understand this pull request has been opened to follow up #494 that Arel does not need encoding magic comments.

I'm wondering which version specified here. At first I was thinking about ">= 2.2.2" as Rails set here But Rails depends on Arel but Arel does not depends on Rails (who uses Arel without Rails or ActiveRecord?) and Travis CI is still testing Arel with Ruby 2.0.0.

I'd like to hear from Rails core team members since version requirement is the one of the very important project decisions.

matthewd commented 7 years ago

Yeah, I'm rather inclined to go to 2.2... partly because it seems rare to use Arel without AR, but mostly just because earlier versions are unsupported anyway.

koic commented 7 years ago

I see. I think that it is reasonable to specify ">= 2.2.2" to required_ruby_version of arel.gemspec. Because I also think that it is rare to use Arel independently from AR. I will update this PR like that if it is OK.

Also, I'd like to do maintenance of travis.yml with another PR. What do you think?

matthewd commented 7 years ago

Yeah, let's go ahead and do that. We can drop the older rubies from travis in this PR too.

koic commented 7 years ago

Thanks for replying. I taken your advice. Maintenance of travis.yml was this PR.

travis.yml made it follow Rails (AR). The summary is as follows.

I updated this PR as described above.