Closed jgraichen closed 6 years ago
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @tenderlove (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.
Steps to reproduce
Output
System configuration
Ruby version:
ruby 2.4.2p198 (2017-09-14 revision 59899) [x86_64-linux]
A fix is attached and all existing specs are passing, but I'm still looking where to add the test from the example above.