search

rails / arel

A Relational Algebra
2.06k stars 390 forks source link

Type-castable attributes should not try to cast SqlLiteral nodes #500

Closed jcoleman closed 7 years ago

rails-bot commented 7 years ago

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @tenderlove (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

jcoleman commented 7 years ago

This is IMO a cleaner fix for #454.