search

rails / arel

A Relational Algebra
2.06k stars 390 forks source link

Better titles #501

Closed abelards closed 6 years ago

abelards commented 6 years ago

I have written a bit more examples of "less trivial" Arel code here, perhaps we can add some of that here: it's often missing in codebases and I've seen way too many people going "the SQL literal way" rather than "the Arel way": https://github.com/rstacruz/cheatsheets/pull/92/files

rails-bot commented 6 years ago

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @tenderlove (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.